Improved Behaviour of use-toast.ts
#1038
Open
+18
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added the option to provide your own
id
when creating a toast, so if an effect runs twice or you instantiate the same toast twice it only gets added once. (dedupe of toasts -> same behaviour as react-hot-toast)I also removed the required id param when updating a toast (the toast hook is already aware of the id of the toast you try to update)
here is the issue linked with this PR: #1039